The coloring sense is properly shàngshǎi, where
色 takes its spoken reading for everyday color. Read shàngsè,
上色 is a separate word meaning top-grade. Speakers do use shàngsè for coloring, especially about digital art, but shǎi is the recorded reading.