引以为荣 is always positive, expressing genuine pride. The opposite is 引以为耻 - to feel ashamed of something.
memory
引 = to draw/cite, 以 = by means of/with, 为 = as, 荣 = glory/honor. The structure means 'to cite it as glory' - to hold something up as a source of pride.
